V641 The size of the allocated memory buffer is not a multiple of the element size. Well, I think average developers won't get a kick out of maintaining such code. Such inserts make it more difficult for the analyzer to match issued warnings with the appropriate files. There are more than 1000 of them in the entire project. #line 1 "./asn1/acse/packet-acse-template.c" Such inserts also don't give a boost to code quality: /* Input file: packet-acse-template.c */ I won't cite same-type code examples, whereas some similar errors take place in hundreds of places. Another factor pointing at the project quality is repeated errors detected by the analyzer. It is typical for the projects, which generally don't use static analysis tools, even free ones. In total, more than 3500 warnings of all levels triggered for this project. What stands out in this case is a great number of PVS-Studio warnings for a small amount of code. It is a subjective assessment, but since we regularly check plenty of projects, I have a frame of reference. Unfortunately, I can't give big points to it. I'd like to draw special attention to the code quality. You can also run the analyzer under Windows and Linux. The choice was wide not only due to the cross platform nature of the project, but also because of that of the analyzer. To analyze the source code, first we needed to compile the project in an OS. To do the source code analysis, we used PVS-Studio static code analyzer. Wireshark is cross-platform, works in such OSs, as: Windows, Linux, macOS, Solaris, FreeBSD, NetBSD and many others. The program works with the vast majority of known protocols, has intuitive and logical graphical interface, an all-powerful system of filters. Wireshark is a well-known tool to capture and analyze network traffic.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |